Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d82fe3dd authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

rsi: fix error code in rsi_load_9116_firmware() 



[ Upstream commit d0f8430332a16c7baa80ce2886339182c5d85f37 ]

This code returns success if the kmemdup() fails, but obviously it
should return -ENOMEM instead.

Fixes: e5a1ecc9 ("rsi: add firmware loading for 9116 device")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20210805103746.GA26417@kili


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 4be8deab

drivers/net/wireless/rsi/rsi_91x_hal.c

+3 −1
Original line number Diff line number Diff line
@@ -1038,8 +1038,10 @@ static int rsi_load_9116_firmware(struct rsi_hw *adapter) 
	}



	ta_firmware = kmemdup(fw_entry->data, fw_entry->size, GFP_KERNEL);

	if (!ta_firmware)

	if (!ta_firmware) {

		status = -ENOMEM;

		goto fail_release_fw;

	}

	fw_p = ta_firmware;

	instructions_sz = fw_entry->size;

	rsi_dbg(INFO_ZONE, "FW Length = %d bytes\n", instructions_sz);