Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d8187b94 authored by Roel Kluin's avatar Roel Kluin Committed by Linus Torvalds
Browse files

dc395x: decrease iteration for tag_number of max_command in start_scsi() 



The tag_number reaches dcb->max_command + 1 after the loop, but when
the tag_number equals dcb->max_command an error message is already
issued. The last iteration therefore appears obsolete.

Signed-off-by: default avatarRoel Kluin <roel.kluin@gmail.com>
Cc: Oliver Neukum <oliver@neukum.name>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 702a98c6

drivers/scsi/dc395x.c

+1 −1
Original line number Diff line number Diff line
@@ -1597,7 +1597,7 @@ static u8 start_scsi(struct AdapterCtlBlk* acb, struct DeviceCtlBlk* dcb, 
		u32 tag_mask = 1;

		u8 tag_number = 0;

		while (tag_mask & dcb->tag_mask

		       && tag_number <= dcb->max_command) {

		       && tag_number < dcb->max_command) {

			tag_mask = tag_mask << 1;

			tag_number++;

		}