Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d81195c4 authored by Jiasheng Jiang's avatar Jiasheng Jiang Committed by Greg Kroah-Hartman
Browse files

intel_th: msu-sink: Potential dereference of null pointer 



[ Upstream commit 82f76a4a720791d889de775b5f7541d601efc8bd ]

The return value of dma_alloc_coherent() needs to be checked.
To avoid use of null pointer in sg_set_buf() in case of the failure of
alloc.

Fixes: f220df66 ("intel_th: msu-sink: An example msu buffer "sink"")
Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarJiasheng Jiang <jiasheng@iscas.ac.cn>
Signed-off-by: default avatarAlexander Shishkin <alexander.shishkin@linux.intel.com>
Link: https://lore.kernel.org/r/20220705082637.59979-3-alexander.shishkin@linux.intel.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 85934222

drivers/hwtracing/intel_th/msu-sink.c

+3 −0
Original line number Diff line number Diff line
@@ -71,6 +71,9 @@ static int msu_sink_alloc_window(void *data, struct sg_table **sgt, size_t size) 
		block = dma_alloc_coherent(priv->dev->parent->parent,

					   PAGE_SIZE, &sg_dma_address(sg_ptr),

					   GFP_KERNEL);

		if (!block)

			return -ENOMEM;



		sg_set_buf(sg_ptr, block, PAGE_SIZE);

	}