Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d80f2666 authored by Julia Lawall's avatar Julia Lawall Committed by David Woodhouse
Browse files

drivers/mtd: Use kmemdup 

Use kmemdup when some other buffer is immediately copied into the
allocated region.

A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression from,to,size,flag;
statement S;
@@

-  to = \(kmalloc\|kzalloc\)(size,flag);
+  to = kmemdup(from,size,flag);
   if (to==NULL || ...) S
-  memcpy(to, from, size);
// </smpl>

Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarDavid Woodhouse <David.Woodhouse@intel.com>
parent abab7ebf

drivers/mtd/mtdconcat.c

+1 −2
Original line number Original line Diff line number Diff line
@@ -183,10 +183,9 @@ concat_writev(struct mtd_info *mtd, const struct kvec *vecs, 
	}

	}





	/* make a copy of vecs */

	/* make a copy of vecs */

	vecs_copy = kmalloc(sizeof(struct kvec) * count, GFP_KERNEL);

	vecs_copy = kmemdup(vecs, sizeof(struct kvec) * count, GFP_KERNEL);

	if (!vecs_copy)

	if (!vecs_copy)

		return -ENOMEM;

		return -ENOMEM;

	memcpy(vecs_copy, vecs, sizeof(struct kvec) * count);





	entry_low = 0;

	entry_low = 0;

	for (i = 0; i < concat->num_subdev; i++) {

	for (i = 0; i < concat->num_subdev; i++) {