Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d7b647d0 authored by Yufen Yu's avatar Yufen Yu Committed by Greg Kroah-Hartman
Browse files

scsi: libsas: Add LUN number check in .slave_alloc callback 

[ Upstream commit 49da96d77938db21864dae6b7736b71e96c1d203 ]

Offlining a SATA device connected to a hisi SAS controller and then
scanning the host will result in detecting 255 non-existent devices:

  # lsscsi
  [2:0:0:0]    disk    ATA      Samsung SSD 860  2B6Q  /dev/sda
  [2:0:1:0]    disk    ATA      WDC WD2003FYYS-3 1D01  /dev/sdb
  [2:0:2:0]    disk    SEAGATE  ST600MM0006      B001  /dev/sdc
  # echo "offline" > /sys/block/sdb/device/state
  # echo "- - -" > /sys/class/scsi_host/host2/scan
  # lsscsi
  [2:0:0:0]    disk    ATA      Samsung SSD 860  2B6Q  /dev/sda
  [2:0:1:0]    disk    ATA      WDC WD2003FYYS-3 1D01  /dev/sdb
  [2:0:1:1]    disk    ATA      WDC WD2003FYYS-3 1D01  /dev/sdh
  ...
  [2:0:1:255]  disk    ATA      WDC WD2003FYYS-3 1D01  /dev/sdjb

After a REPORT LUN command issued to the offline device fails, the SCSI
midlayer tries to do a sequential scan of all devices whose LUN number is
not 0. However, SATA does not support LUN numbers at all.

Introduce a generic sas_slave_alloc() handler which will return -ENXIO for
SATA devices if the requested LUN number is larger than 0 and make libsas
drivers use this function as their .slave_alloc callback.

Link: https://lore.kernel.org/r/20210622034037.1467088-1-yuyufen@huawei.com


Reported-by: default avatarWu Bo <wubo40@huawei.com>
Suggested-by: default avatarJohn Garry <john.garry@huawei.com>
Reviewed-by: default avatarJohn Garry <john.garry@huawei.com>
Reviewed-by: default avatarJason Yan <yanaijie@huawei.com>
Signed-off-by: default avatarYufen Yu <yuyufen@huawei.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 863c4bc8

drivers/scsi/aic94xx/aic94xx_init.c

+1 −0
Original line number Diff line number Diff line
@@ -52,6 +52,7 @@ static struct scsi_host_template aic94xx_sht = { 
	.max_sectors		= SCSI_DEFAULT_MAX_SECTORS,

	.eh_device_reset_handler	= sas_eh_device_reset_handler,

	.eh_target_reset_handler	= sas_eh_target_reset_handler,

	.slave_alloc		= sas_slave_alloc,

	.target_destroy		= sas_target_destroy,

	.ioctl			= sas_ioctl,

	.track_queue_depth	= 1,

drivers/scsi/hisi_sas/hisi_sas_v1_hw.c

+1 −0
Original line number Diff line number Diff line
@@ -1768,6 +1768,7 @@ static struct scsi_host_template sht_v1_hw = { 
	.max_sectors		= SCSI_DEFAULT_MAX_SECTORS,

	.eh_device_reset_handler = sas_eh_device_reset_handler,

	.eh_target_reset_handler = sas_eh_target_reset_handler,

	.slave_alloc		= sas_slave_alloc,

	.target_destroy		= sas_target_destroy,

	.ioctl			= sas_ioctl,

	.shost_attrs		= host_attrs_v1_hw,

drivers/scsi/hisi_sas/hisi_sas_v2_hw.c

+1 −0
Original line number Diff line number Diff line
@@ -3542,6 +3542,7 @@ static struct scsi_host_template sht_v2_hw = { 
	.max_sectors		= SCSI_DEFAULT_MAX_SECTORS,

	.eh_device_reset_handler = sas_eh_device_reset_handler,

	.eh_target_reset_handler = sas_eh_target_reset_handler,

	.slave_alloc		= sas_slave_alloc,

	.target_destroy		= sas_target_destroy,

	.ioctl			= sas_ioctl,

	.shost_attrs		= host_attrs_v2_hw,

drivers/scsi/hisi_sas/hisi_sas_v3_hw.c

+1 −0
Original line number Diff line number Diff line
@@ -3064,6 +3064,7 @@ static struct scsi_host_template sht_v3_hw = { 
	.max_sectors		= SCSI_DEFAULT_MAX_SECTORS,

	.eh_device_reset_handler = sas_eh_device_reset_handler,

	.eh_target_reset_handler = sas_eh_target_reset_handler,

	.slave_alloc		= sas_slave_alloc,

	.target_destroy		= sas_target_destroy,

	.ioctl			= sas_ioctl,

	.shost_attrs		= host_attrs_v3_hw,

drivers/scsi/isci/init.c

+1 −0
Original line number Diff line number Diff line
@@ -166,6 +166,7 @@ static struct scsi_host_template isci_sht = { 
	.eh_abort_handler		= sas_eh_abort_handler,

	.eh_device_reset_handler        = sas_eh_device_reset_handler,

	.eh_target_reset_handler        = sas_eh_target_reset_handler,

	.slave_alloc			= sas_slave_alloc,

	.target_destroy			= sas_target_destroy,

	.ioctl				= sas_ioctl,

	.shost_attrs			= isci_host_attrs,