Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d7a39937 authored by Julian Wiedmann's avatar Julian Wiedmann Committed by David S. Miller
Browse files

s390/qeth: remove unused return value 



qeth_qdio_output_handler() is the only caller of
qeth_handle_send_error() and doesn't care about the return value.

Signed-off-by: default avatarJulian Wiedmann <jwi@linux.vnet.ibm.com>
Signed-off-by: default avatarUrsula Braun <ubraun@linux.vnet.ibm.com>
Reviewed-by: default avatarThomas Richter <tmricht@linux.vnet.ibm.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent bbeb2414

drivers/s390/net/qeth_core.h

+0 −7
Original line number Diff line number Diff line
@@ -503,13 +503,6 @@ struct qeth_qdio_info { 
	int default_out_queue;

};



enum qeth_send_errors {

	QETH_SEND_ERROR_NONE,

	QETH_SEND_ERROR_LINK_FAILURE,

	QETH_SEND_ERROR_RETRY,

	QETH_SEND_ERROR_KICK_IT,

};



#define QETH_ETH_MAC_V4      0x0100 /* like v4 */

#define QETH_ETH_MAC_V6      0x3333 /* like v6 */

/* tr mc mac is longer, but that will be enough to detect mc frames */

drivers/s390/net/qeth_core_main.c

+3 −4
Original line number Diff line number Diff line
@@ -3322,7 +3322,7 @@ void qeth_queue_input_buffer(struct qeth_card *card, int index) 
}

EXPORT_SYMBOL_GPL(qeth_queue_input_buffer);



static int qeth_handle_send_error(struct qeth_card *card,

static void qeth_handle_send_error(struct qeth_card *card,

		struct qeth_qdio_out_buffer *buffer, unsigned int qdio_err)

{

	int sbalf15 = buffer->buffer->element[15].sflags;
@@ -3338,15 +3338,14 @@ static int qeth_handle_send_error(struct qeth_card *card, 
	qeth_check_qdio_errors(card, buffer->buffer, qdio_err, "qouterr");



	if (!qdio_err)

		return QETH_SEND_ERROR_NONE;

		return;



	if ((sbalf15 >= 15) && (sbalf15 <= 31))

		return QETH_SEND_ERROR_RETRY;

		return;



	QETH_CARD_TEXT(card, 1, "lnkfail");

	QETH_CARD_TEXT_(card, 1, "%04x %02x",

		       (u16)qdio_err, (u8)sbalf15);

	return QETH_SEND_ERROR_LINK_FAILURE;

}



/*