Commit d79749f7 authored Aug 29, 2019 by Miaoqing Pan Committed by Kalle Valo Oct 14, 2019

ath10k: fix latency issue for QCA988x



(kvalo: cherry picked from commit 1340cc631bd00431e2f174525c971f119df9efa1 in
wireless-drivers-next to wireless-drivers as this a frequently reported
regression)

Bad latency is found on QCA988x, the issue was introduced by
commit 4504f0e5 ("ath10k: sdio: workaround firmware UART
pin configuration bug"). If uart_pin_workaround is false, this
change will set uart pin even if uart_print is false.

Tested HW: QCA9880
Tested FW: 10.2.4-1.0-00037

Fixes: 4504f0e5 ("ath10k: sdio: workaround firmware UART pin configuration bug")
Signed-off-by: Miaoqing Pan <miaoqing@codeaurora.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

parent 3aed8837

drivers/net/wireless/ath/ath10k/core.c

+9 −6

Original line number	Diff line number	Diff line
		@@ -2118,13 +2118,16 @@ static int ath10k_init_uart(struct ath10k *ar)
		return ret;
		}

		if (!uart_print && ar->hw_params.uart_pin_workaround) {
		if (!uart_print) {
		if (ar->hw_params.uart_pin_workaround) {
		ret = ath10k_bmi_write32(ar, hi_dbg_uart_txpin,
		ar->hw_params.uart_pin);
		if (ret) {
		ath10k_warn(ar, "failed to set UART TX pin: %d", ret);
		ath10k_warn(ar, "failed to set UART TX pin: %d",
		ret);
		return ret;
		}
		}

		return 0;
		}