Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d74d0899 authored by Sergio Paracuellos's avatar Sergio Paracuellos Committed by Greg Kroah-Hartman
Browse files

staging: ks7010: refactor LOCAL_EEPROM_SUM case in hostif_mib_get_confirm 



This commit simplify conditional paths in LOCAL_EEPROM_SUM case
inside hostif_mib_get_confirm function. It change logic to handle
invalid values first and assign good ones at the end if it is the
case.

Signed-off-by: default avatarSergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5089cd41

drivers/staging/ks7010/ks_hostif.c

+7 −10
Original line number Diff line number Diff line
@@ -504,18 +504,15 @@ void hostif_mib_get_confirm(struct ks_wlan_private *priv) 
		break;

	case LOCAL_EEPROM_SUM:

		memcpy(&priv->eeprom_sum, priv->rxp, sizeof(priv->eeprom_sum));

		if (priv->eeprom_sum.type == 0) {

			priv->eeprom_checksum = EEPROM_CHECKSUM_NONE;

		} else if (priv->eeprom_sum.type == 1) {

			if (priv->eeprom_sum.result == 0) {

				priv->eeprom_checksum = EEPROM_NG;

				netdev_info(dev, "LOCAL_EEPROM_SUM NG\n");

			} else if (priv->eeprom_sum.result == 1) {

				priv->eeprom_checksum = EEPROM_OK;

			}

		} else {

		if (priv->eeprom_sum.type != 0 &&

		    priv->eeprom_sum.type != 1) {

			netdev_err(dev, "LOCAL_EEPROM_SUM error!\n");

			return;

		}

		priv->eeprom_checksum = (priv->eeprom_sum.type == 0) ?

					 EEPROM_CHECKSUM_NONE :

					 (priv->eeprom_sum.result == 0) ?

					 EEPROM_NG : EEPROM_OK;

		break;

	default:

		netdev_err(priv->net_dev, "mib_attribute=%08x\n",