Commit d73e8c47 authored Mar 13, 2023 by Alexander Stein Committed by Greg Kroah-Hartman May 30, 2023

regmap: cache: Return error in cache sync operations for REGCACHE_NONE



[ Upstream commit fd883d79e4dcd2417c2b80756f22a2ff03b0f6e0 ]

There is no sense in doing a cache sync on REGCACHE_NONE regmaps.
Instead of panicking the kernel due to missing cache_ops, return an error
to client driver.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Link: https://lore.kernel.org/r/20230313071812.13577-1-alexander.stein@ew.tq-group.com


Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 9b72cb39

drivers/base/regmap/regcache.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -343,6 +343,9 @@ int regcache_sync(struct regmap *map)
		const char *name;
		bool bypass;

		if (WARN_ON(map->cache_type == REGCACHE_NONE))
		return -EINVAL;

		BUG_ON(!map->cache_ops);

		map->lock(map->lock_arg);
		@@ -412,6 +415,9 @@ int regcache_sync_region(struct regmap *map, unsigned int min,
		const char *name;
		bool bypass;

		if (WARN_ON(map->cache_type == REGCACHE_NONE))
		return -EINVAL;

		BUG_ON(!map->cache_ops);

		map->lock(map->lock_arg);