Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d697f78c authored by Wei Yongjun's avatar Wei Yongjun Committed by Greg Kroah-Hartman
Browse files

net: bgmac: Drop free_netdev() from bgmac_enet_remove() 



[ Upstream commit 6f928ab8ee9bfbcb0e631c47ea8a16c3d5116ff1 ]

netdev is allocated in bgmac_alloc() with devm_alloc_etherdev() and will
be auto released in ->remove and ->probe failure path. Using free_netdev()
in bgmac_enet_remove() leads to double free.

Fixes: 34a5102c ("net: bgmac: allocate struct bgmac just once & don't copy it")
Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>

Link: https://lore.kernel.org/r/20221109150136.2991171-1-weiyongjun@huaweicloud.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent bec9ded5

drivers/net/ethernet/broadcom/bgmac.c

+0 −1
Original line number Diff line number Diff line
@@ -1564,7 +1564,6 @@ void bgmac_enet_remove(struct bgmac *bgmac) 
	phy_disconnect(bgmac->net_dev->phydev);

	netif_napi_del(&bgmac->napi);

	bgmac_dma_free(bgmac);

	free_netdev(bgmac->net_dev);

}

EXPORT_SYMBOL_GPL(bgmac_enet_remove);