Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d6643d12 authored by Hiroshi Shimamoto's avatar Hiroshi Shimamoto Committed by Ingo Molnar
Browse files

latencytop: fix memory leak on latency proc file 



At lstats_open(), calling get_proc_task() gets task struct, but it never put.
put_task_struct() should be called when releasing.

Signed-off-by: default avatarHiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent ae002786

fs/proc/base.c

+10 −1
Original line number Diff line number Diff line
@@ -360,6 +360,15 @@ static int lstats_open(struct inode *inode, struct file *file) 
	return ret;

}



static int lstats_release(struct inode *inode, struct file *file)

{

	struct seq_file *m = file->private_data;

	struct task_struct *task = m->private;



	put_task_struct(task);

	return single_release(inode, file);

}



static ssize_t lstats_write(struct file *file, const char __user *buf,

			    size_t count, loff_t *offs)

{
@@ -378,7 +387,7 @@ static const struct file_operations proc_lstats_operations = { 
	.read		= seq_read,

	.write		= lstats_write,

	.llseek		= seq_lseek,

	.release	= single_release,

	.release	= lstats_release,

};



#endif