Commit d6250e00 authored Feb 15, 2023 by Christophe JAILLET Committed by Greg Kroah-Hartman Mar 11, 2023

spi: synquacer: Fix timeout handling in synquacer_spi_transfer_one()



[ Upstream commit e6a0b671880207566e1ece983bf989dde60bc1d7 ]

wait_for_completion_timeout() never returns a <0 value. It returns either
on timeout or a positive value (at least 1, or number of jiffies left
till timeout)

So, fix the error handling path and return -ETIMEDOUT should a timeout
occur.

Fixes: b0823ee3 ("spi: Add spi driver for Socionext SynQuacer platform")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Jassi Brar <jaswinder.singh@linaro.org>
Link: https://lore.kernel.org/r/c2040bf3cfa201fd8890cfab14fa5a701ffeca14.1676466072.git.christophe.jaillet@wanadoo.fr


Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent b89d2ed5

drivers/spi/spi-synquacer.c

+3 −4

Original line number	Diff line number	Diff line
		@@ -472,10 +472,9 @@ static int synquacer_spi_transfer_one(struct spi_master *master,
		read_fifo(sspi);
		}

		if (status < 0) {
		dev_err(sspi->dev, "failed to transfer. status: 0x%x\n",
		status);
		return status;
		if (status == 0) {
		dev_err(sspi->dev, "failed to transfer. Timeout.\n");
		return -ETIMEDOUT;
		}

		return 0;