Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d5bcb2f9 authored by Stephen Boyd's avatar Stephen Boyd Committed by Greg Kroah-Hartman
Browse files

i2c: qcom-geni: Let firmware specify irq trigger flags 



[ Upstream commit b2ca8800621b95ecced081376de9fe256b1fa479 ]

We don't need to force IRQF_TRIGGER_HIGH here as the DT or ACPI tables
should take care of this for us. Just use 0 instead so that we use the
flags from the firmware. Also, remove specify dev_name() for the irq
name so that we can get better information in /proc/interrupts about
which device is generating interrupts.

Cc: Alok Chauhan <alokc@codeaurora.org>
Reviewed-by: default avatarDouglas Anderson <dianders@chromium.org>
Reviewed-by: default avatarBrendan Higgins <brendanhiggins@google.com>
Signed-off-by: default avatarStephen Boyd <swboyd@chromium.org>
Reviewed-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
Reviewed-by: default avatarAmit Kucheria <amit.kucheria@linaro.org>
Signed-off-by: default avatarWolfram Sang <wsa@the-dreams.de>
Stable-dep-of: e2c85d85a05f ("i2c: qcom-geni: Use IRQF_NO_AUTOEN flag in request_irq()")
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent dd6a664b

drivers/i2c/busses/i2c-qcom-geni.c

+2 −2
Original line number Diff line number Diff line
@@ -576,8 +576,8 @@ static int geni_i2c_probe(struct platform_device *pdev) 
	init_completion(&gi2c->done);

	spin_lock_init(&gi2c->lock);

	platform_set_drvdata(pdev, gi2c);

	ret = devm_request_irq(&pdev->dev, gi2c->irq, geni_i2c_irq,

			       IRQF_TRIGGER_HIGH, "i2c_geni", gi2c);

	ret = devm_request_irq(&pdev->dev, gi2c->irq, geni_i2c_irq, 0,

			       dev_name(&pdev->dev), gi2c);

	if (ret) {

		dev_err(&pdev->dev, "Request_irq failed:%d: err:%d\n",

			gi2c->irq, ret);