Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d5a7ee66 authored by Sai Chaitanya Kaveti's avatar Sai Chaitanya Kaveti
Browse files

msm: mhi_dev: Changing the GFP flag in alloc_skb() 



GFP_ATOMIC flag is typically used in memory allocations inside
interrupt handlers or with spin locks. It is of high priority but it
does not allow the caller to reclaim the memory allocation request.
This may lead to memory allocation failures in low memory situations.

Since alloc_skb() is not called from interrupt handler or in spin lock
context, changing the GFP flag from GFP_ATOMIC to GFP_KERNEL.

Change-Id: I6c3a2b5b4674965cf1d4860e9072fa46cd4adddb
Signed-off-by: default avatarSai Chaitanya Kaveti <quic_skaveti@quicinc.com>
parent 37a3bfb6

drivers/platform/msm/mhi_dev/mhi_dev_net.c

+1 −1
Original line number Diff line number Diff line
@@ -279,7 +279,7 @@ static ssize_t mhi_dev_net_client_read(struct mhi_dev_net_client *mhi_handle) 
				struct mhi_req, list);

		list_del_init(&req->list);

		spin_unlock_irqrestore(&mhi_handle->rd_lock, flags);

		skb = alloc_skb(MHI_NET_DEFAULT_MTU, GFP_ATOMIC);

		skb = alloc_skb(MHI_NET_DEFAULT_MTU, GFP_KERNEL);

		if (skb == NULL) {

			pr_err("%s(): skb alloc failed\n", __func__);

			spin_lock_irqsave(&mhi_handle->rd_lock, flags);