Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d58ef256 authored by Liang He's avatar Liang He Committed by Greg Kroah-Hartman
Browse files

drm/meson: Fix refcount bugs in meson_vpu_has_available_connectors() 



[ Upstream commit 91b3c8dbe898df158fd2a84675f3a284ff6666f7 ]

In this function, there are two refcount leak bugs:
(1) when breaking out of for_each_endpoint_of_node(), we need call
the of_node_put() for the 'ep';
(2) we should call of_node_put() for the reference returned by
of_graph_get_remote_port() when it is not used anymore.

Fixes: bbbe775e ("drm: Add support for Amlogic Meson Graphic Controller")
Signed-off-by: default avatarLiang He <windhl@126.com>
Acked-by: default avatarMartin Blumenstingl <martin.blumenstingl@googlemail.com>
Acked-by: default avatarNeil Armstrong <narmstrong@baylibre.com>
Signed-off-by: default avatarNeil Armstrong <narmstrong@baylibre.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220726010722.1319416-1-windhl@126.com


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent d0c4307a

drivers/gpu/drm/meson/meson_drv.c

+4 −1
Original line number Diff line number Diff line
@@ -124,9 +124,12 @@ static bool meson_vpu_has_available_connectors(struct device *dev) 
	for_each_endpoint_of_node(dev->of_node, ep) {

		/* If the endpoint node exists, consider it enabled */

		remote = of_graph_get_remote_port(ep);

		if (remote)

		if (remote) {

			of_node_put(remote);

			of_node_put(ep);

			return true;

		}

	}



	return false;

}