Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d56e1fcb authored by Tudor Ambarus's avatar Tudor Ambarus Committed by Greg Kroah-Hartman
Browse files

dmaengine: at_xdmac: Print debug message after realeasing the lock 



commit 5edc24ac876a928f36f407a0fcdb33b94a3a210f upstream.

It is desirable to do the prints without the lock held if possible, so
move the print after the lock is released.

Fixes: e1f7c9ee ("dmaengine: at_xdmac: creation of the atmel eXtended DMA Controller driver")
Signed-off-by: default avatarTudor Ambarus <tudor.ambarus@microchip.com>
Link: https://lore.kernel.org/r/20211215110115.191749-4-tudor.ambarus@microchip.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7163076f

drivers/dma/at_xdmac.c

+4 −2
Original line number Original line Diff line number Diff line
@@ -424,10 +424,12 @@ static dma_cookie_t at_xdmac_tx_submit(struct dma_async_tx_descriptor *tx) 
	spin_lock_irqsave(&atchan->lock, irqflags);

	spin_lock_irqsave(&atchan->lock, irqflags);

	cookie = dma_cookie_assign(tx);

	cookie = dma_cookie_assign(tx);





	dev_vdbg(chan2dev(tx->chan), "%s: atchan 0x%p, add desc 0x%p to xfers_list\n",

		 __func__, atchan, desc);

	list_add_tail(&desc->xfer_node, &atchan->xfers_list);

	list_add_tail(&desc->xfer_node, &atchan->xfers_list);

	spin_unlock_irqrestore(&atchan->lock, irqflags);

	spin_unlock_irqrestore(&atchan->lock, irqflags);



	dev_vdbg(chan2dev(tx->chan), "%s: atchan 0x%p, add desc 0x%p to xfers_list\n",

		 __func__, atchan, desc);



	return cookie;

	return cookie;

}

}