Commit d55b7fdd authored Jul 31, 2019 by Geert Uytterhoeven Committed by Linus Walleij Aug 05, 2019

pinctrl: xway: Use devm_kasprintf() instead of fixed buffer formatting

Improve readability and maintainability by replacing a hardcoded string
allocation and formatting by the use of the devm_kasprintf() helper.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20190731132917.17607-4-geert+renesas@glider.be

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 811604d0

drivers/pinctrl/pinctrl-xway.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -1731,13 +1731,11 @@ static int pinmux_xway_probe(struct platform_device *pdev)
		return -ENOMEM;

		for (i = 0; i < xway_chip.ngpio; i++) {
		/* strlen("ioXY") + 1 = 5 */
		char *name = devm_kzalloc(&pdev->dev, 5, GFP_KERNEL);
		char *name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "io%d", i);

		if (!name)
		return -ENOMEM;

		snprintf(name, 5, "io%d", i);
		xway_info.pads[i].number = GPIO0 + i;
		xway_info.pads[i].name = name;
		}