Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d553cc95 authored by Devin Heitmueller's avatar Devin Heitmueller Committed by Mauro Carvalho Chehab
Browse files

V4L/DVB (9923): xc5000: remove init_fw option 



The init_fw option was broken for the HVR-950q because we would call the reset
callback inside of dvb_attach() and the callback had not been setup yet.

Michael Krufky (who added the init_fw feature) says it's no longer required,
so just remove the option completely.

Thanks to user Zzeiss from #linuxtv chat for reporting the issue and
Michael Krufky <mkrufky@linuxtv.org> for proposing the fix.

Signed-off-by: default avatarDevin Heitmueller <dheitmueller@linuxtv.org>
Acked-by: default avatarMichael Krufky <mkrufky@linuxtv.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent c665f4dd

drivers/media/common/tuners/xc5000.c

+0 −7
Original line number Diff line number Diff line
@@ -36,10 +36,6 @@ static int debug; 
module_param(debug, int, 0644);

MODULE_PARM_DESC(debug, "Turn on/off debugging (default:off).");



static int xc5000_load_fw_on_attach;

module_param_named(init_fw, xc5000_load_fw_on_attach, int, 0644);

MODULE_PARM_DESC(init_fw, "Load firmware during driver initialization.");



static DEFINE_MUTEX(xc5000_list_mutex);

static LIST_HEAD(hybrid_tuner_instance_list);
@@ -1017,9 +1013,6 @@ struct dvb_frontend *xc5000_attach(struct dvb_frontend *fe, 
	memcpy(&fe->ops.tuner_ops, &xc5000_tuner_ops,

		sizeof(struct dvb_tuner_ops));



	if (xc5000_load_fw_on_attach)

		xc5000_init(fe);



	return fe;

fail:

	mutex_unlock(&xc5000_list_mutex);