Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d54a1979 authored by Himanshu Shukla's avatar Himanshu Shukla Committed by Casey Schaufler
Browse files

SMACK: Delete list_head repeated initialization 



smk_copy_rules() and smk_copy_relabel() are initializing list_head though
they have been initialized already in new_task_smack() function. Delete
repeated initialization.

Signed-off-by: default avatarHimanshu Shukla <himanshu.sh@samsung.com>
Signed-off-by: default avatarCasey Schaufler <casey@schaufler-ca.com>
parent 2e962e2f

security/smack/smack_lsm.c

+0 −4
Original line number Diff line number Diff line
@@ -348,8 +348,6 @@ static int smk_copy_rules(struct list_head *nhead, struct list_head *ohead, 
	struct smack_rule *orp;

	int rc = 0;



	INIT_LIST_HEAD(nhead);



	list_for_each_entry_rcu(orp, ohead, list) {

		nrp = kzalloc(sizeof(struct smack_rule), gfp);

		if (nrp == NULL) {
@@ -376,8 +374,6 @@ static int smk_copy_relabel(struct list_head *nhead, struct list_head *ohead, 
	struct smack_known_list_elem *nklep;

	struct smack_known_list_elem *oklep;



	INIT_LIST_HEAD(nhead);



	list_for_each_entry(oklep, ohead, list) {

		nklep = kzalloc(sizeof(struct smack_known_list_elem), gfp);

		if (nklep == NULL) {