Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d47648fc authored by Shaohua Li's avatar Shaohua Li Committed by NeilBrown
Browse files

raid5: avoid finding "discard" stripe 



SCSI discard will damage discard stripe bio setting, eg, some fields are
changed. If the stripe is reused very soon, we have wrong bios setting. We
remove discard stripe from hash list, so next time the strip will be fully
initialized.

Suitable for backport to 3.7+.

Cc: <stable@vger.kernel.org> (3.7+)
Signed-off-by: default avatarShaohua Li <shli@fusionio.com>
Signed-off-by: default avatarNeilBrown <neilb@suse.de>
parent 37c61ff3

drivers/md/raid5.c

+8 −0
Original line number Diff line number Diff line
@@ -2922,6 +2922,14 @@ static void handle_stripe_clean_event(struct r5conf *conf, 
		}

		/* now that discard is done we can proceed with any sync */

		clear_bit(STRIPE_DISCARD, &sh->state);

		/*

		 * SCSI discard will change some bio fields and the stripe has

		 * no updated data, so remove it from hash list and the stripe

		 * will be reinitialized

		 */

		spin_lock_irq(&conf->device_lock);

		remove_hash(sh);

		spin_unlock_irq(&conf->device_lock);

		if (test_bit(STRIPE_SYNC_REQUESTED, &sh->state))

			set_bit(STRIPE_HANDLE, &sh->state);