Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d4040fad authored by Víctor Manuel Jáquez Leal's avatar Víctor Manuel Jáquez Leal Committed by Greg Kroah-Hartman
Browse files

staging: tidspbridge: remove cod_init() and cod_exit() 



The cod module has a cod_init() and a cod_exit() whose only purpose is
to keep a reference counting which is not used at all.

This patch removes these functions and the reference count variable.

There is no functional changes.

Signed-off-by: default avatarVíctor Manuel Jáquez Leal <vjaquez@igalia.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1f2cd527

drivers/staging/tidspbridge/include/dspbridge/cod.h

+0 −29
Original line number Diff line number Diff line
@@ -99,21 +99,6 @@ extern int cod_create(struct cod_manager **mgr, 
 */

extern void cod_delete(struct cod_manager *cod_mgr_obj);



/*

 *  ======== cod_exit ========

 *  Purpose:

 *      Discontinue usage of the COD module.

 *  Parameters:

 *      None.

 *  Returns:

 *      None.

 *  Requires:

 *      COD initialized.

 *  Ensures:

 *      Resources acquired in cod_init(void) are freed.

 */

extern void cod_exit(void);



/*

 *  ======== cod_get_base_lib ========

 *  Purpose:
@@ -242,20 +227,6 @@ extern int cod_get_section(struct cod_libraryobj *lib, 
extern int cod_get_sym_value(struct cod_manager *cod_mgr_obj,

				    char *str_sym, u32 * pul_value);



/*

 *  ======== cod_init ========

 *  Purpose:

 *      Initialize the COD module's private state.

 *  Parameters:

 *      None.

 *  Returns:

 *      TRUE if initialized; FALSE if error occurred.

 *  Requires:

 *  Ensures:

 *      A requirement for each of the other public COD functions.

 */

extern bool cod_init(void);



/*

 *  ======== cod_load_base ========

 *  Purpose:

drivers/staging/tidspbridge/pmgr/cod.c

+0 −29
Original line number Diff line number Diff line
@@ -58,8 +58,6 @@ struct cod_libraryobj { 
	struct cod_manager *cod_mgr;

};



static u32 refs = 0L;



static struct dbll_fxns ldr_fxns = {

	(dbll_close_fxn) dbll_close,

	(dbll_create_fxn) dbll_create,
@@ -267,17 +265,6 @@ void cod_delete(struct cod_manager *cod_mgr_obj) 
	kfree(cod_mgr_obj);

}



/*

 *  ======== cod_exit ========

 *  Purpose:

 *      Discontinue usage of the COD module.

 *

 */

void cod_exit(void)

{

	refs--;

}



/*

 *  ======== cod_get_base_lib ========

 *  Purpose:
@@ -394,22 +381,6 @@ int cod_get_sym_value(struct cod_manager *cod_mgr_obj, char *str_sym, 
	return 0;

}



/*

 *  ======== cod_init ========

 *  Purpose:

 *      Initialize the COD module's private state.

 *

 */

bool cod_init(void)

{

	bool ret = true;



	if (ret)

		refs++;



	return ret;

}



/*

 *  ======== cod_load_base ========

 *  Purpose:

drivers/staging/tidspbridge/pmgr/dspapi.c

+2 −7
Original line number Diff line number Diff line
@@ -267,7 +267,6 @@ void api_exit(void) 


	if (api_c_refs == 0) {

		/* Release all modules initialized in api_init(). */

		cod_exit();

		dev_exit();

		chnl_exit();

		msg_exit();
@@ -289,7 +288,7 @@ void api_exit(void) 
bool api_init(void)

{

	bool ret = true;

	bool fdev, fcod, fchnl, fmsg, fio;

	bool fdev, fchnl, fmsg, fio;

	bool fmgr, fproc, fnode, fdisp, fstrm, frmm;



	if (api_c_refs == 0) {
@@ -304,8 +303,7 @@ bool api_init(void) 
		fmsg = msg_mod_init();

		fio = io_init();

		fdev = dev_init();

		fcod = cod_init();

		ret = fdev && fchnl && fcod && fmsg && fio;

		ret = fdev && fchnl && fmsg && fio;

		ret = ret && fmgr && fproc && frmm;

		if (!ret) {
@@ -336,9 +334,6 @@ bool api_init(void) 
			if (fdev)

				dev_exit();



			if (fcod)

				cod_exit();



			if (frmm)

				rmm_exit();

drivers/staging/tidspbridge/rmgr/dbdcd.c

+1 −14
Original line number Diff line number Diff line
@@ -289,7 +289,6 @@ void dcd_exit(void) 


	refs--;

	if (refs == 0) {

		cod_exit();

		list_for_each_entry_safe(rv, rv_tmp, &reg_key_list, link) {

			list_del(&rv->link);

			kfree(rv->path);
@@ -738,22 +737,10 @@ int dcd_get_library_name(struct dcd_manager *hdcd_mgr, 
 */

bool dcd_init(void)

{

	bool init_cod;

	bool ret = true;



	if (refs == 0) {

		/* Initialize required modules. */

		init_cod = cod_init();



		if (!init_cod) {

			ret = false;

			/* Exit initialized modules. */

			if (init_cod)

				cod_exit();

		}



	if (refs == 0)

		INIT_LIST_HEAD(&reg_key_list);

	}



	if (ret)

		refs++;