Commit d3edf648 authored Jun 17, 2020 by Julian Wiedmann Committed by Sasha Levin Jun 30, 2020

s390/qeth: fix error handling for isolation mode cmds



[ Upstream commit e2dfcfba00ba4a414617ef4c5a8501fe21567eb3 ]

Current(?) OSA devices also store their cmd-specific return codes for
SET_ACCESS_CONTROL cmds into the top-level cmd->hdr.return_code.
So once we added stricter checking for the top-level field a while ago,
none of the error logic that rolls back the user's configuration to its
old state is applied any longer.

For this specific cmd, go back to the old model where we peek into the
cmd structure even though the top-level field indicated an error.

Fixes: 686c97ee ("s390/qeth: fix error handling in adapter command callbacks")
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 9e89c2d5

drivers/s390/net/qeth_core_main.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -4163,9 +4163,6 @@ static int qeth_setadpparms_set_access_ctrl_cb(struct qeth_card *card,
		int fallback = (int )reply->param;

		QETH_CARD_TEXT(card, 4, "setaccb");
		if (cmd->hdr.return_code)
		return -EIO;
		qeth_setadpparms_inspect_rc(cmd);

		access_ctrl_req = &cmd->data.setadapterparms.data.set_access_ctrl;
		QETH_CARD_TEXT_(card, 2, "rc=%d",
		@@ -4175,7 +4172,7 @@ static int qeth_setadpparms_set_access_ctrl_cb(struct qeth_card *card,
		QETH_DBF_MESSAGE(3, "ERR:SET_ACCESS_CTRL(%#x) on device %x: %#x\n",
		access_ctrl_req->subcmd_code, CARD_DEVID(card),
		cmd->data.setadapterparms.hdr.return_code);
		switch (cmd->data.setadapterparms.hdr.return_code) {
		switch (qeth_setadpparms_inspect_rc(cmd)) {
		case SET_ACCESS_CTRL_RC_SUCCESS:
		if (card->options.isolation == ISOLATION_MODE_NONE) {
		dev_info(&card->gdev->dev,