Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d3c1e33f authored by Julia Lawall's avatar Julia Lawall Committed by Viresh Kumar
Browse files

cpufreq: ap806: add missing of_node_put after of_device_is_available 

Add an of_node_put when a tested device node is not available.

The semantic patch that fixes this problem is as follows
(http://coccinelle.lip6.fr

):

// <smpl>
@@
identifier f;
local idexpression e;
expression x;
@@

e = f(...);
... when != of_node_put(e)
    when != x = e
    when != e = x
    when any
if (<+...of_device_is_available(e)...+>) {
  ... when != of_node_put(e)
(
  return e;
|
+ of_node_put(e);
  return ...;
)
}
// </smpl>

Fixes: f525a670 ("cpufreq: ap806: add cpufreq driver for Armada 8K")
Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
parent f525a670

drivers/cpufreq/armada-8k-cpufreq.c

+3 −1
Original line number Diff line number Diff line
@@ -128,8 +128,10 @@ static int __init armada_8k_cpufreq_init(void) 
	struct cpumask cpus;



	node = of_find_compatible_node(NULL, NULL, "marvell,ap806-cpu-clock");

	if (!node || !of_device_is_available(node))

	if (!node || !of_device_is_available(node)) {

		of_node_put(node);

		return -ENODEV;

	}



	nb_cpus = num_possible_cpus();

	freq_tables = kcalloc(nb_cpus, sizeof(*freq_tables), GFP_KERNEL);