Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d38ca8f0 authored by Colin Ian King's avatar Colin Ian King Committed by Alex Deucher
Browse files

drm/amdgpu: fix missing assignment of error return code to variable ret 



An earlier commit replaced ttm_bo_wait with amdgpu_bo_sync_wait and
removed the error return assignment to variable ret. Fix this by adding
the assignment back. Also break line to clean up checkpatch overly
long line warning.

Detected by CoverityScan, CID#1477327 ("Logically dead code")

Fixes: c60cd590 ("drm/amdgpu: Replace ttm_bo_wait with amdgpu_bo_sync_wait")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent b849aaa4

drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c

+2 −1
Original line number Diff line number Diff line
@@ -878,7 +878,8 @@ static int init_kfd_vm(struct amdgpu_vm *vm, void **process_info, 
		pr_err("validate_pt_pd_bos() failed\n");

		goto validate_pd_fail;

	}

	amdgpu_bo_sync_wait(vm->root.base.bo, AMDGPU_FENCE_OWNER_KFD, false);

	ret = amdgpu_bo_sync_wait(vm->root.base.bo,

				  AMDGPU_FENCE_OWNER_KFD, false);

	if (ret)

		goto wait_pd_fail;

	amdgpu_bo_fence(vm->root.base.bo,