Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d359886a authored by Saravana Kannan's avatar Saravana Kannan Committed by Greg Kroah-Hartman
Browse files

driver core: Release all resources during unbind before updating device links 



commit 2e84dc37920012b458e9458b19fc4ed33f81bc74 upstream.

This commit fixes a bug in commit 9ed98953 ("driver core: Functional
dependencies tracking support") where the device link status was
incorrectly updated in the driver unbind path before all the device's
resources were released.

Fixes: 9ed98953 ("driver core: Functional dependencies tracking support")
Cc: stable <stable@kernel.org>
Reported-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Closes: https://lore.kernel.org/all/20231014161721.f4iqyroddkcyoefo@pengutronix.de/


Signed-off-by: default avatarSaravana Kannan <saravanak@google.com>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Yang Yingliang <yangyingliang@huawei.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Matti Vaittinen <mazziesaccount@gmail.com>
Cc: James Clark <james.clark@arm.com>
Acked-by: default avatar"Rafael J. Wysocki" <rafael@kernel.org>
Tested-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20231018013851.3303928-1-saravanak@google.com


Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 8e221b47

drivers/base/dd.c

+2 −2
Original line number Diff line number Diff line
@@ -1162,8 +1162,6 @@ static void __device_release_driver(struct device *dev, struct device *parent) 
		else if (drv->remove)

			drv->remove(dev);



		device_links_driver_cleanup(dev);



		devres_release_all(dev);

		arch_teardown_dma_ops(dev);

		dev->driver = NULL;
@@ -1173,6 +1171,8 @@ static void __device_release_driver(struct device *dev, struct device *parent) 
		pm_runtime_reinit(dev);

		dev_pm_set_driver_flags(dev, 0);



		device_links_driver_cleanup(dev);



		klist_remove(&dev->p->knode_driver);

		device_pm_check_callbacks(dev);

		if (dev->bus)