Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d3566abb authored by Nicholas Piggin's avatar Nicholas Piggin Committed by Martin K. Petersen
Browse files

scsi: qla2xxx: stop timer in shutdown path 

In shutdown/reboot paths, the timer is not stopped:

  qla2x00_shutdown
  pci_device_shutdown
  device_shutdown
  kernel_restart_prepare
  kernel_restart
  sys_reboot

This causes lockups (on powerpc) when firmware config space access calls
are interrupted by smp_send_stop later in reboot.

Fixes: e30d1756 ("[SCSI] qla2xxx: Addition of shutdown callback handler.")
Link: https://lore.kernel.org/r/20191024063804.14538-1-npiggin@gmail.com


Signed-off-by: default avatarNicholas Piggin <npiggin@gmail.com>
Acked-by: default avatarHimanshu Madhani <hmadhani@marvell.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 0cf9f4e5

drivers/scsi/qla2xxx/qla_os.c

+4 −0
Original line number Diff line number Diff line
@@ -3529,6 +3529,10 @@ qla2x00_shutdown(struct pci_dev *pdev) 
		qla2x00_try_to_stop_firmware(vha);

	}



	/* Disable timer */

	if (vha->timer_active)

		qla2x00_stop_timer(vha);



	/* Turn adapter off line */

	vha->flags.online = 0;