Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d2f588f9 authored by Richard Genoud's avatar Richard Genoud Committed by Artem Bityutskiy
Browse files

UBI: check max_beb_per1024 value in ubi_attach_mtd_dev 



max_beb_per1024 shouldn't be negative, and a 0 value will be treated as
the default value. For the upper bound, 768/1024 should be enough.

Signed-off-by: default avatarRichard Genoud <richard.genoud@gmail.com>
Signed-off-by: default avatarArtem Bityutskiy <artem.bityutskiy@linux.intel.com>
parent 256334c3

drivers/mtd/ubi/build.c

+9 −0
Original line number Diff line number Diff line
@@ -49,6 +49,9 @@ 
/* Maximum number of comma-separated items in the 'mtd=' parameter */

#define MTD_PARAM_MAX_COUNT 2



/* Maximum value for the number of bad PEBs per 1024 PEBs */

#define MAX_MTD_UBI_BEB_LIMIT 768



#ifdef CONFIG_MTD_UBI_MODULE

#define ubi_is_module() 1

#else
@@ -852,6 +855,12 @@ int ubi_attach_mtd_dev(struct mtd_info *mtd, int ubi_num, 
	struct ubi_device *ubi;

	int i, err, ref = 0;



	if (max_beb_per1024 < 0 || max_beb_per1024 > MAX_MTD_UBI_BEB_LIMIT)

		return -EINVAL;



	if (!max_beb_per1024)

		max_beb_per1024 = CONFIG_MTD_UBI_BEB_LIMIT;



	/*

	 * Check if we already have the same MTD device attached.

	 *