Commit d26454ee authored Jul 29, 2019 by Andrey Smirnov Committed by Greg Kroah-Hartman Sep 04, 2019

tty: serial: fsl_lpuart: Drop no-op bit opearation



The check for termios->c_cflag & CRTSCTS ensure that if we reach else
branch, CRTSCTS in termios->c_cflag is already going to be
cleard. Doing so explicitly there is not necessary. Drop it.

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: Stefan Agner <stefan@agner.ch>
Cc: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
Cc: Chris Healy <cphealy@gmail.com>
Cc: Cory Tusar <cory.tusar@zii.aero>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.com>
Cc: linux-imx@nxp.com
Cc: linux-serial@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Link: https://lore.kernel.org/r/20190729195226.8862-11-andrew.smirnov@gmail.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 93b9523a

drivers/tty/serial/fsl_lpuart.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -1650,12 +1650,10 @@ lpuart_set_termios(struct uart_port port, struct ktermios termios,
		if (sport->port.rs485.flags & SER_RS485_ENABLED)
		termios->c_cflag &= ~CRTSCTS;

		if (termios->c_cflag & CRTSCTS) {
		if (termios->c_cflag & CRTSCTS)
		modem \|= (UARTMODEM_RXRTSE \| UARTMODEM_TXCTSE);
		} else {
		termios->c_cflag &= ~CRTSCTS;
		else
		modem &= ~(UARTMODEM_RXRTSE \| UARTMODEM_TXCTSE);
		}

		if (termios->c_cflag & CSTOPB)
		termios->c_cflag &= ~CSTOPB;