Commit d25ed413 authored Feb 26, 2019 by Heiner Kallweit Committed by David S. Miller Mar 01, 2019

net: phy: phylink: fix uninitialized variable in phylink_get_mac_state



When debugging an issue I found implausible values in state->pause.
Reason in that state->pause isn't initialized and later only single
bits are changed. Also the struct itself isn't initialized in
phylink_resolve(). So better initialize state->pause and other
not yet initialized fields.

v2:
- use right function name in subject
v3:
- initialize additional fields

Fixes: 9525ae83 ("phylink: add phylink infrastructure")
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 15f3ddf5

drivers/net/phy/phylink.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -320,6 +320,10 @@ static int phylink_get_mac_state(struct phylink pl, struct phylink_link_state
		linkmode_zero(state->lp_advertising);
		state->interface = pl->link_config.interface;
		state->an_enabled = pl->link_config.an_enabled;
		state->speed = SPEED_UNKNOWN;
		state->duplex = DUPLEX_UNKNOWN;
		state->pause = MLO_PAUSE_NONE;
		state->an_complete = 0;
		state->link = 1;

		return pl->ops->mac_link_state(ndev, state);