Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d24aae41 authored by Chuck Lever's avatar Chuck Lever Committed by Trond Myklebust
Browse files

NFS: Use size_t for storing name lengths 



Clean up: always use the same type when handling buffer lengths.  As a
bonus, this prevents a mixed sign comparison in idmap_lookup_name.

Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
parent a661b77f

fs/nfs/idmap.c

+3 −3
Original line number Diff line number Diff line
@@ -74,7 +74,7 @@ module_param_call(idmap_cache_timeout, param_set_idmap_timeout, param_get_int, 
struct idmap_hashent {

	unsigned long		ih_expires;

	__u32			ih_id;

	int			ih_namelen;

	size_t			ih_namelen;

	char			ih_name[IDMAP_NAMESZ];

};
@@ -193,7 +193,7 @@ idmap_lookup_id(struct idmap_hashtable *h, __u32 id) 
 * pretty trivial.

 */

static inline struct idmap_hashent *

idmap_alloc_name(struct idmap_hashtable *h, char *name, unsigned len)

idmap_alloc_name(struct idmap_hashtable *h, char *name, size_t len)

{

	return idmap_name_hash(h, name, len);

}
@@ -381,7 +381,7 @@ idmap_pipe_downcall(struct file *filp, const char __user *src, size_t mlen) 
	struct idmap_msg im_in, *im = &idmap->idmap_im;

	struct idmap_hashtable *h;

	struct idmap_hashent *he = NULL;

	int namelen_in;

	size_t namelen_in;

	int ret;



	if (mlen != sizeof(im_in))