Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d1f305ec authored by Ashish Kumar Dhanotiya's avatar Ashish Kumar Dhanotiya
Browse files

qcacld-3.0: Do not cache connection info for non sta interface 

Currently driver does not check the mode of the current interface
whether it is STA of CLI and it caches the connection info, in this
process it allocates the memory to cache he operation, this memory
get freed only for station type adapter because of which there is
a possibility of memleak for CLI interface.
To avoid above issue, add a change to only cache the information
STA interface.

Change-Id: Ic68d71dfd9887600fe1a287de66d735c2c802491
CRs-Fixed: 3028583
parent 5dd57b12

core/hdd/src/wlan_hdd_assoc.c

+13 −6
Original line number Diff line number Diff line
@@ -1139,15 +1139,22 @@ static void hdd_save_bss_info(struct hdd_adapter *adapter, 
		hdd_sta_ctx->conn_info.conn_flag.vht_op_present = false;

	}



	/*

	 * Cache connection info only in case of station

	 */



	if (adapter->device_mode == QDF_STA_MODE) {

		/* Cleanup already existing he info */

		hdd_cleanup_conn_info(adapter);



		/* Cache last connection info */

	qdf_mem_copy(&hdd_sta_ctx->cache_conn_info, &hdd_sta_ctx->conn_info,

		qdf_mem_copy(&hdd_sta_ctx->cache_conn_info,

			     &hdd_sta_ctx->conn_info,

			     sizeof(hdd_sta_ctx->cache_conn_info));



		hdd_copy_he_operation(hdd_sta_ctx, roam_info);

	}

}



/**

 * hdd_conn_save_connect_info() - save current connection information