Commit d1c627b5 authored Oct 01, 2009 by Uwe Kleine-König Committed by Linus Torvalds Oct 01, 2009

spi-imx: initialize complete config struct

Otherwise the config function uses random data from the stack.  This
didn't stick out because config is called once more in the chipselect
function with correct parameters.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Cc: David Brownell <dbrownell@users.sourceforge.net>
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 4388eb11

drivers/spi/spi_imx.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -442,6 +442,7 @@ static int spi_imx_setupxfer(struct spi_device *spi,
		config.bpw = t ? t->bits_per_word : spi->bits_per_word;
		config.speed_hz = t ? t->speed_hz : spi->max_speed_hz;
		config.mode = spi->mode;
		config.cs = spi_imx->chipselect[spi->chip_select];

		if (!config.speed_hz)
		config.speed_hz = spi->max_speed_hz;