Commit d19bd485 authored Feb 08, 2023 by Qi Zheng Committed by Greg Kroah-Hartman Mar 11, 2023

OPP: fix error checking in opp_migrate_dentry()



[ Upstream commit eca4c0eea53432ec4b711b2a8ad282cbad231b4f ]

Since commit ff9fb72b ("debugfs: return error values,
not NULL") changed return value of debugfs_rename() in
error cases from %NULL to %ERR_PTR(-ERROR), we should
also check error values instead of NULL.

Fixes: ff9fb72b ("debugfs: return error values, not NULL")
Signed-off-by: Qi Zheng <zhengqi.arch@bytedance.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 522d319c

drivers/opp/debugfs.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -162,7 +162,7 @@ static void opp_migrate_dentry(struct opp_device *opp_dev,

	dentry = debugfs_rename(rootdir, opp_dev->dentry, rootdir,		dentry = debugfs_rename(rootdir, opp_dev->dentry, rootdir,
	opp_table->dentry_name);		opp_table->dentry_name);
	if (!dentry) {		if (IS_ERR(dentry)) {
	dev_err(dev, "%s: Failed to rename link from: %s to %s\n",		dev_err(dev, "%s: Failed to rename link from: %s to %s\n",
	__func__, dev_name(opp_dev->dev), dev_name(dev));		__func__, dev_name(opp_dev->dev), dev_name(dev));
	return;		return;