Commit d1592d3e authored Jun 07, 2022 by Miaoqian Lin Committed by Greg Kroah-Hartman Jun 29, 2022

drm/msm/mdp4: Fix refcount leak in mdp4_modeset_init_intf



[ Upstream commit b9cc4598607cb7f7eae5c75fc1e3209cd52ff5e0 ]

of_graph_get_remote_node() returns remote device node pointer with
refcount incremented, we should use of_node_put() on it
when not need anymore.
Add missing of_node_put() to avoid refcount leak.

Fixes: 86418f90 ("drm: convert drivers to use of_graph_get_remote_node")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Patchwork: https://patchwork.freedesktop.org/patch/488473/
Link: https://lore.kernel.org/r/20220607110841.53889-1-linmq006@gmail.com


Signed-off-by: Rob Clark <robdclark@chromium.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent f1f9c2a5

drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -245,6 +245,7 @@ static int mdp4_modeset_init_intf(struct mdp4_kms *mdp4_kms,
		encoder = mdp4_lcdc_encoder_init(dev, panel_node);
		if (IS_ERR(encoder)) {
		DRM_DEV_ERROR(dev->dev, "failed to construct LCDC encoder\n");
		of_node_put(panel_node);
		return PTR_ERR(encoder);
		}

		@@ -254,6 +255,7 @@ static int mdp4_modeset_init_intf(struct mdp4_kms *mdp4_kms,
		connector = mdp4_lvds_connector_init(dev, panel_node, encoder);
		if (IS_ERR(connector)) {
		DRM_DEV_ERROR(dev->dev, "failed to initialize LVDS connector\n");
		of_node_put(panel_node);
		return PTR_ERR(connector);
		}