Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d0d6bc89 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

USB: ohci-dbg.c: move assignment out of if () block 



We should not be doing assignments within an if () block
so fix up the code to not do this.

change was created using Coccinelle.

Acked-by: default avatarAlan Stern <stern@rowland.harvard.edu>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: default avatarFelipe Balbi <balbi@ti.com>
parent 4c08ccf0

drivers/usb/host/ohci-dbg.c

+4 −2
Original line number Diff line number Diff line
@@ -491,7 +491,8 @@ static ssize_t fill_periodic_buffer(struct debug_buffer *buf) 
	char			*next;

	unsigned		i;



	if (!(seen = kmalloc (DBG_SCHED_LIMIT * sizeof *seen, GFP_ATOMIC)))

	seen = kmalloc(DBG_SCHED_LIMIT * sizeof *seen, GFP_ATOMIC);

	if (!seen)

		return 0;

	seen_count = 0;
@@ -506,7 +507,8 @@ static ssize_t fill_periodic_buffer(struct debug_buffer *buf) 
	/* dump a snapshot of the periodic schedule (and load) */

	spin_lock_irqsave (&ohci->lock, flags);

	for (i = 0; i < NUM_INTS; i++) {

		if (!(ed = ohci->periodic [i]))

		ed = ohci->periodic[i];

		if (!ed)

			continue;



		temp = scnprintf (next, size, "%2d [%3d]:", i, ohci->load [i]);