Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d0c3730f authored by Ian Abbott's avatar Ian Abbott Committed by Greg Kroah-Hartman
Browse files

comedi: vmk80xx: fix expression for tx buffer size 



commit 242439f7e279d86b3f73b5de724bc67b2f8aeb07 upstream.

The expression for setting the size of the allocated bulk TX buffer
(`devpriv->usb_tx_buf`) is calling `usb_endpoint_maxp(devpriv->ep_rx)`,
which is using the wrong endpoint (should be `devpriv->ep_tx`).  Fix it.

Fixes: a23461c47482 ("comedi: vmk80xx: fix transfer-buffer overflow")
Cc: Johan Hovold <johan@kernel.org>
Cc: stable@vger.kernel.org # 4.9+
Reviewed-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarIan Abbott <abbotti@mev.co.uk>
Link: https://lore.kernel.org/r/20220607171819.4121-1-abbotti@mev.co.uk


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent bf833c48

drivers/staging/comedi/drivers/vmk80xx.c

+1 −1
Original line number Diff line number Diff line
@@ -685,7 +685,7 @@ static int vmk80xx_alloc_usb_buffers(struct comedi_device *dev) 
	if (!devpriv->usb_rx_buf)

		return -ENOMEM;



	size = max(usb_endpoint_maxp(devpriv->ep_rx), MIN_BUF_SIZE);

	size = max(usb_endpoint_maxp(devpriv->ep_tx), MIN_BUF_SIZE);

	devpriv->usb_tx_buf = kzalloc(size, GFP_KERNEL);

	if (!devpriv->usb_tx_buf)

		return -ENOMEM;