Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d0c0d902 authored by Colin Ian King's avatar Colin Ian King Committed by Martin K. Petersen
Browse files

scsi: bnx2fc: fix incorrect cast to u64 on shift operation 



Currently an int is being shifted and the result is being cast to a u64
which leads to undefined behaviour if the shift is more than 31 bits. Fix
this by casting the integer value 1 to u64 before the shift operation.

Addresses-Coverity: ("Bad shift operation")
Fixes: 7b594769 ("[SCSI] bnx2fc: Handle REC_TOV error code from firmware")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Acked-by: default avatarSaurav Kashyap <skashyap@marvell.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 8ef860ae

drivers/scsi/bnx2fc/bnx2fc_hwi.c

+1 −1
Original line number Diff line number Diff line
@@ -830,7 +830,7 @@ static void bnx2fc_process_unsol_compl(struct bnx2fc_rport *tgt, u16 wqe) 
			((u64)err_entry->data.err_warn_bitmap_hi << 32) |

			(u64)err_entry->data.err_warn_bitmap_lo;

		for (i = 0; i < BNX2FC_NUM_ERR_BITS; i++) {

			if (err_warn_bit_map & (u64) (1 << i)) {

			if (err_warn_bit_map & ((u64)1 << i)) {

				err_warn = i;

				break;

			}