Commit d0ab87f8 authored Feb 01, 2022 by Hector Martin Committed by Greg Kroah-Hartman Apr 15, 2022

brcmfmac: pcie: Release firmwares in the brcmf_pcie_setup error path



commit 5e90f0f3ead014867dade7a22f93958119f5efab upstream.

This avoids leaking memory if brcmf_chip_get_raminfo fails. Note that
the CLM blob is released in the device remove path.

Fixes: 82f93cf4 ("brcmfmac: get chip's default RAM info during PCIe setup")
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Cc: stable@vger.kernel.org
Signed-off-by: Hector Martin <marcan@marcan.st>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20220131160713.245637-2-marcan@marcan.st


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 2c894b12

drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1775,6 +1775,8 @@ static void brcmf_pcie_setup(struct device *dev, int ret,
		ret = brcmf_chip_get_raminfo(devinfo->ci);
		if (ret) {
		brcmf_err(bus, "Failed to get RAM info\n");
		release_firmware(fw);
		brcmf_fw_nvram_free(nvram);
		goto fail;
		}