Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d0717a95 authored by Alexander Lobakin's avatar Alexander Lobakin Committed by Sasha Levin
Browse files

net: qede: stop adding events on an already destroyed workqueue 



[ Upstream commit 4079c7f7a2a00ab403c177ce723b560de59139c3 ]

Set rdma_wq pointer to NULL after destroying the workqueue and check
for it when adding new events to fix crashes on driver unload.

Fixes: cee9fbd8 ("qede: Add qedr framework")
Signed-off-by: default avatarAlexander Lobakin <alobakin@marvell.com>
Signed-off-by: default avatarIgor Russkikh <irusskikh@marvell.com>
Signed-off-by: default avatarMichal Kalderon <michal.kalderon@marvell.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 164d9a15

drivers/net/ethernet/qlogic/qede/qede_rdma.c

+2 −1
Original line number Diff line number Diff line
@@ -105,6 +105,7 @@ static void qede_rdma_destroy_wq(struct qede_dev *edev) 


	qede_rdma_cleanup_event(edev);

	destroy_workqueue(edev->rdma_info.rdma_wq);

	edev->rdma_info.rdma_wq = NULL;

}



int qede_rdma_dev_add(struct qede_dev *edev, bool recovery)
@@ -325,7 +326,7 @@ static void qede_rdma_add_event(struct qede_dev *edev, 
	if (edev->rdma_info.exp_recovery)

		return;



	if (!edev->rdma_info.qedr_dev)

	if (!edev->rdma_info.qedr_dev || !edev->rdma_info.rdma_wq)

		return;



	/* We don't want the cleanup flow to start while we're allocating and