Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d053d56f authored by Aditya Bavanari's avatar Aditya Bavanari
Browse files

dsp: Fix a memory leak issue when nvmem read returns invalid length 



When nvmem cell read returns invalid length the allocated buffer
is not freed. Free the buffer in this scenario to fix
memory leak issue.

Change-Id: I2e0010c1cfb2ea03cb4f25abf55e94ce4f0c5fcf
Signed-off-by: default avatarAditya Bavanari <abavanar@codeaurora.org>
parent 315e4b16

dsp/adsp-loader.c

+7 −1
Original line number Original line Diff line number Diff line
@@ -388,10 +388,16 @@ static int adsp_loader_probe(struct platform_device *pdev) 
	}

	}

	buf = nvmem_cell_read(cell, &len);

	buf = nvmem_cell_read(cell, &len);

	nvmem_cell_put(cell);

	nvmem_cell_put(cell);

	if (IS_ERR_OR_NULL(buf) || len <= 0 || len > sizeof(u32)) {

	if (IS_ERR_OR_NULL(buf)) {

		dev_dbg(&pdev->dev, "%s: FAILED to read nvmem cell \n", __func__);

		dev_dbg(&pdev->dev, "%s: FAILED to read nvmem cell \n", __func__);

		goto wqueue;

		goto wqueue;

	}

	}

	if (len <= 0 || len > sizeof(u32)) {

		dev_dbg(&pdev->dev, "%s: nvmem cell length out of range: %d\n",

			__func__, len);

		kfree(buf);

		goto wqueue;

	}

	memcpy(&adsp_var_idx, buf, len);

	memcpy(&adsp_var_idx, buf, len);

	kfree(buf);

	kfree(buf);