Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d0310dc4 authored by Emil Tantilov's avatar Emil Tantilov Committed by Jeff Kirsher
Browse files

ixgbe: fix possible data corruption in read_i2c_byte 



This patch makes sure that the SW lock is released after all i2c
operations complete in the retry code path.

Signed-off-by: default avatarEmil Tantilov <emil.s.tantilov@intel.com>
Tested-by: default avatarPhil Schmitt <phillip.j.schmitt@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent 4c696ca9

drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c

+1 −1
Original line number Diff line number Diff line
@@ -1307,9 +1307,9 @@ s32 ixgbe_read_i2c_byte_generic(struct ixgbe_hw *hw, u8 byte_offset, 
		break;



fail:

		ixgbe_i2c_bus_clear(hw);

		hw->mac.ops.release_swfw_sync(hw, swfw_mask);

		msleep(100);

		ixgbe_i2c_bus_clear(hw);

		retry++;

		if (retry < max_retry)

			hw_dbg(hw, "I2C byte read error - Retrying.\n");