Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cf9138c9 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Greg Kroah-Hartman
Browse files

platform/x86/intel: punit_ipc: Drop wrong use of ACPI_PTR() 



[ Upstream commit 349bff48ae0f5f8aa2075d0bdc2091a30bd634f6 ]

ACPI_PTR() is more harmful than helpful. For example, in this case
if CONFIG_ACPI=n, the ID table left unused which is not what we want.

Instead of adding ifdeffery here and there, drop ACPI_PTR()
and unused acpi.h.

Fixes: fdca4f16 ("platform:x86: add Intel P-Unit mailbox IPC driver")
Reported-by: default avatarkernel test robot <lkp@intel.com>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20210827145310.76239-1-andriy.shevchenko@linux.intel.com


Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent a8e8b148

drivers/platform/x86/intel_punit_ipc.c

+1 −2
Original line number Original line Diff line number Diff line
@@ -8,7 +8,6 @@ 
 * which provide mailbox interface for power management usage.

 * which provide mailbox interface for power management usage.

 */

 */





#include <linux/acpi.h>

#include <linux/bitops.h>

#include <linux/bitops.h>

#include <linux/delay.h>

#include <linux/delay.h>

#include <linux/device.h>

#include <linux/device.h>
@@ -335,7 +334,7 @@ static struct platform_driver intel_punit_ipc_driver = { 
	.remove = intel_punit_ipc_remove,

	.remove = intel_punit_ipc_remove,

	.driver = {

	.driver = {

		.name = "intel_punit_ipc",

		.name = "intel_punit_ipc",

		.acpi_match_table = ACPI_PTR(punit_ipc_acpi_ids),

		.acpi_match_table = punit_ipc_acpi_ids,

	},

	},

};

};