Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cf8c7aa9 authored by Paulo Alcantara (SUSE)'s avatar Paulo Alcantara (SUSE) Committed by Greg Kroah-Hartman
Browse files

cifs: Get rid of kstrdup_const()'d paths 



commit 199c6bdfb04b71d88a7765e08285885fbca60df4 upstream.

The DFS cache API is mostly used with heap allocated strings.

Signed-off-by: default avatarPaulo Alcantara (SUSE) <pc@cjr.nz>
Reviewed-by: default avatarAurelien Aptel <aaptel@suse.com>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
Signed-off-by: default avatarRishabh Bhatnagar <risbhat@amazon.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3fa4c081

fs/cifs/dfs_cache.c

+3 −3
Original line number Diff line number Diff line
@@ -131,7 +131,7 @@ static inline void flush_cache_ent(struct cache_entry *ce) 
		return;



	hlist_del_init_rcu(&ce->hlist);

	kfree_const(ce->path);

	kfree(ce->path);

	free_tgts(ce);

	cache_count--;

	call_rcu(&ce->rcu, free_cache_entry);
@@ -420,7 +420,7 @@ static struct cache_entry *alloc_cache_entry(const char *path, 
	if (!ce)

		return ERR_PTR(-ENOMEM);



	ce->path = kstrdup_const(path, GFP_KERNEL);

	ce->path = kstrndup(path, strlen(path), GFP_KERNEL);

	if (!ce->path) {

		kmem_cache_free(cache_slab, ce);

		return ERR_PTR(-ENOMEM);
@@ -430,7 +430,7 @@ static struct cache_entry *alloc_cache_entry(const char *path, 


	rc = copy_ref_data(refs, numrefs, ce, NULL);

	if (rc) {

		kfree_const(ce->path);

		kfree(ce->path);

		kmem_cache_free(cache_slab, ce);

		ce = ERR_PTR(rc);

	}