Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cf2acec2 authored by Steve Glendinning's avatar Steve Glendinning Committed by David S. Miller
Browse files

smsc95xx: sleep before read for lengthy operations 



During init, the device reset is unexpected to complete immediately,
so sleep before testing the condition rather than after it.

Signed-off-by: default avatarSteve Glendinning <steve.glendinning@shawell.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6a06e5e1

drivers/net/usb/smsc95xx.c

+2 −2
Original line number Diff line number Diff line
@@ -763,12 +763,12 @@ static int smsc95xx_reset(struct usbnet *dev) 


	timeout = 0;

	do {

		msleep(10);

		ret = smsc95xx_read_reg(dev, HW_CFG, &read_buf);

		if (ret < 0) {

			netdev_warn(dev->net, "Failed to read HW_CFG: %d\n", ret);

			return ret;

		}

		msleep(10);

		timeout++;

	} while ((read_buf & HW_CFG_LRST_) && (timeout < 100));
@@ -786,12 +786,12 @@ static int smsc95xx_reset(struct usbnet *dev) 


	timeout = 0;

	do {

		msleep(10);

		ret = smsc95xx_read_reg(dev, PM_CTRL, &read_buf);

		if (ret < 0) {

			netdev_warn(dev->net, "Failed to read PM_CTRL: %d\n", ret);

			return ret;

		}

		msleep(10);

		timeout++;

	} while ((read_buf & PM_CTL_PHY_RST_) && (timeout < 100));