Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cf22644a authored by Martin Brandenburg's avatar Martin Brandenburg Committed by Mike Marshall
Browse files

orangefs: use S_ISREG(mode) and friends instead of mode & S_IFREG. 



Suggestion from Dan Carpenter.

Signed-off-by: default avatarMartin Brandenburg <martin@omnibond.com>
Signed-off-by: default avatarMike Marshall <hubcap@omnibond.com>
parent 78699e29

fs/orangefs/orangefs-utils.c

+3 −3
Original line number Diff line number Diff line
@@ -428,17 +428,17 @@ static int compare_attributes_to_inode(struct inode *inode, 


	switch (attrs->objtype) {

	case ORANGEFS_TYPE_METAFILE:

		if (!(inode->i_mode & S_IFREG))

		if (!S_ISREG(inode->i_mode))

			return 0;

		break;

	case ORANGEFS_TYPE_DIRECTORY:

		if (!(inode->i_mode & S_IFDIR))

		if (!S_ISDIR(inode->i_mode))

			return 0;

		if (inode->i_nlink != 1)

			return 0;

		break;

	case ORANGEFS_TYPE_SYMLINK:

		if (!(inode->i_mode & S_IFLNK))

		if (!S_ISLNK(inode->i_mode))

			return 0;

		if (orangefs_inode && symname &&

		    mask & ORANGEFS_ATTR_SYS_LNK_TARGET)