Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cee7a6a2 authored by Leo Yan's avatar Leo Yan Committed by Arnaldo Carvalho de Melo
Browse files

perf cs-etm: Remove unused 'trace_on' in cs_etm_decoder 



cs_etm_decoder::trace_on is being assigned when TRACE_ON or NO_SYNC
element is coming, but it is never used hence it is redundant and can
be removed.

So let's remove 'trace_on' field from cs_etm_decoder struct.

Suggested-by: default avatarMathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: default avatarLeo Yan <leo.yan@linaro.org>
Reviewed-by: default avatarMathieu Poirier <mathieu.poirier@linaro.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Mike Leach <mike.leach@linaro.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Robert Walker <robert.walker@arm.com>
Cc: coresight@lists.linaro.org
Cc: linux-arm-kernel@lists.infradead.org
Link: http://lkml.kernel.org/r/1544513908-16805-4-git-send-email-leo.yan@linaro.org


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 24fff5eb

tools/perf/util/cs-etm-decoder/cs-etm-decoder.c

+0 −3
Original line number Diff line number Diff line
@@ -36,7 +36,6 @@ 
struct cs_etm_decoder {

	void *data;

	void (*packet_printer)(const char *msg);

	bool trace_on;

	dcd_tree_handle_t dcd_tree;

	cs_etm_mem_cb_type mem_access;

	ocsd_datapath_resp_t prev_return;
@@ -411,12 +410,10 @@ static ocsd_datapath_resp_t cs_etm_decoder__gen_trace_elem_printer( 
	case OCSD_GEN_TRC_ELEM_UNKNOWN:

		break;

	case OCSD_GEN_TRC_ELEM_NO_SYNC:

		decoder->trace_on = false;

		break;

	case OCSD_GEN_TRC_ELEM_TRACE_ON:

		resp = cs_etm_decoder__buffer_trace_on(decoder,

						       trace_chan_id);

		decoder->trace_on = true;

		break;

	case OCSD_GEN_TRC_ELEM_INSTR_RANGE:

		resp = cs_etm_decoder__buffer_range(decoder, elem,