Commit cecaa76b authored Jul 05, 2019 by Frank de Brabander Committed by David S. Miller Jul 08, 2019

selftests: txring_overwrite: fix incorrect test of mmap() return value



If mmap() fails it returns MAP_FAILED, which is defined as ((void *) -1).
The current if-statement incorrectly tests if *ring is NULL.

Fixes: 358be656 ("selftests/net: add txring_overwrite")
Signed-off-by: Frank de Brabander <debrabander@gmail.com>
Acked-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent dd006fc4

tools/testing/selftests/net/txring_overwrite.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -113,7 +113,7 @@ static int setup_tx(char **ring)

		ring = mmap(0, req.tp_block_size req.tp_block_nr,
		PROT_READ \| PROT_WRITE, MAP_SHARED, fdt, 0);
		if (!*ring)
		if (*ring == MAP_FAILED)
		error(1, errno, "mmap");

		return fdt;