Commit ceabee6c authored Mar 21, 2019 by YueHaibing Committed by David S. Miller Mar 21, 2019

genetlink: Fix a memory leak on error path



In genl_register_family(), when idr_alloc() fails,
we forget to free the memory we possibly allocate for
family->attrbuf.

Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 2ae0f17d ("genetlink: use idr to track families")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Kirill Tkhai <ktkhai@virtuozzo.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 33872d79

net/netlink/genetlink.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -366,7 +366,7 @@ int genl_register_family(struct genl_family *family)
		start, end + 1, GFP_KERNEL);
		if (family->id < 0) {
		err = family->id;
		goto errout_locked;
		goto errout_free;
		}

		err = genl_validate_assign_mc_groups(family);
		@@ -385,6 +385,7 @@ int genl_register_family(struct genl_family *family)

		errout_remove:
		idr_remove(&genl_fam_idr, family->id);
		errout_free:
		kfree(family->attrbuf);
		errout_locked:
		genl_unlock_all();