Commit cea743f2 authored Jul 11, 2019 by Gustavo A. R. Silva Committed by Jason Gunthorpe Jul 11, 2019

RDMA/siw: Mark expected switch fall-throughs



In preparation to enabling -Wimplicit-fallthrough, mark switch cases where
we are expecting to fall through.

This patch fixes the following warnings:

drivers/infiniband/sw/siw/siw_qp_rx.c: In function ‘siw_rdmap_complete’:
drivers/infiniband/sw/siw/siw_qp_rx.c:1214:18: warning: this statement may fall through [-Wimplicit-fallthrough=]
   wqe->rqe.flags |= SIW_WQE_SOLICITED;
   ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
drivers/infiniband/sw/siw/siw_qp_rx.c:1215:2: note: here
  case RDMAP_SEND:
  ^~~~

drivers/infiniband/sw/siw/siw_qp_tx.c: In function ‘siw_qp_sq_process’:
drivers/infiniband/sw/siw/siw_qp_tx.c:1044:4: warning: this statement may fall through [-Wimplicit-fallthrough=]
    siw_wqe_put_mem(wqe, tx_type);
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/infiniband/sw/siw/siw_qp_tx.c:1045:3: note: here
   case SIW_OP_INVAL_STAG:
   ^~~~
drivers/infiniband/sw/siw/siw_qp_tx.c:1128:4: warning: this statement may fall through [-Wimplicit-fallthrough=]
    siw_wqe_put_mem(wqe, tx_type);
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/infiniband/sw/siw/siw_qp_tx.c:1129:3: note: here
   case SIW_OP_INVAL_STAG:
   ^~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Bernard Metzler <bmt@zurich.ibm.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

parent bedc0fd0

drivers/infiniband/sw/siw/siw_qp_rx.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1212,6 +1212,8 @@ static int siw_rdmap_complete(struct siw_qp *qp, int error)
		case RDMAP_SEND_SE:
		case RDMAP_SEND_SE_INVAL:
		wqe->rqe.flags \|= SIW_WQE_SOLICITED;
		/* Fall through */

		case RDMAP_SEND:
		case RDMAP_SEND_INVAL:
		if (wqe->wr_status == SIW_WR_IDLE)

drivers/infiniband/sw/siw/siw_qp_tx.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -1042,6 +1042,8 @@ int siw_qp_sq_process(struct siw_qp *qp)
		case SIW_OP_SEND_REMOTE_INV:
		case SIW_OP_WRITE:
		siw_wqe_put_mem(wqe, tx_type);
		/* Fall through */

		case SIW_OP_INVAL_STAG:
		case SIW_OP_REG_MR:
		if (tx_flags(wqe) & SIW_WQE_SIGNALLED)
		@@ -1126,6 +1128,8 @@ int siw_qp_sq_process(struct siw_qp *qp)
		case SIW_OP_READ:
		case SIW_OP_READ_LOCAL_INV:
		siw_wqe_put_mem(wqe, tx_type);
		/* Fall through */

		case SIW_OP_INVAL_STAG:
		case SIW_OP_REG_MR:
		siw_sqe_complete(qp, &wqe->sqe, wqe->bytes,