Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cea6633d authored by Michael S. Tsirkin's avatar Michael S. Tsirkin Committed by Greg Kroah-Hartman
Browse files

virtio_balloon: fix up endian-ness for free cmd id 



commit 168c358af2f8c5a37f8b5f877ba2cc93995606ee upstream.

free cmd id is read using virtio endian, spec says all fields
in balloon are LE. Fix it up.

Fixes: 86a55978 ("virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Acked-by: default avatarJason Wang <jasowang@redhat.com>
Reviewed-by: default avatarWei Wang <wei.w.wang@intel.com>
Acked-by: default avatarDavid Hildenbrand <david@redhat.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c2f787f9

drivers/virtio/virtio_balloon.c

+5 −1
Original line number Diff line number Diff line
@@ -529,10 +529,14 @@ static int init_vqs(struct virtio_balloon *vb) 
static u32 virtio_balloon_cmd_id_received(struct virtio_balloon *vb)

{

	if (test_and_clear_bit(VIRTIO_BALLOON_CONFIG_READ_CMD_ID,

			       &vb->config_read_bitmap))

			       &vb->config_read_bitmap)) {

		virtio_cread(vb->vdev, struct virtio_balloon_config,

			     free_page_report_cmd_id,

			     &vb->cmd_id_received_cache);

		/* Legacy balloon config space is LE, unlike all other devices. */

		if (!virtio_has_feature(vb->vdev, VIRTIO_F_VERSION_1))

			vb->cmd_id_received_cache = le32_to_cpu((__force __le32)vb->cmd_id_received_cache);

	}



	return vb->cmd_id_received_cache;

}